foudfou / firetray-legacy

Automatically exported from code.google.com/p/firetray
Other
2 stars 1 forks source link

Ctrl+W on last tab closes FF instead of mimize to tray #79

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. several tabs opened
2. press Ctrl+W until last tab left
3. next Ctrl+W closes FF (Firetray tray icon disappears), if I close window
with mouse it minimizes to tray as I expect 

What is the expected output? What do you see instead?
minimize to tray when closing last tab with Ctrl+W 

What version of the product are you using? On what operating system?
Linux Ubuntu 8.10, FF 3.0.15, Firetray 0.2.3.

Please provide any additional information below.
Firetrays preferences:
  [x] Close button minimizes to tray
  [ ] Start program minimized
  [x] Confirm application exit

Original issue reported on code.google.com by mschayna on 3 Nov 2009 at 7:52

GoogleCodeExporter commented 9 years ago
This behaviour is the one expected. Ctrl+W is not equivalent to pressing the 
close
button. 

Original comment by fsoltr...@gmail.com on 29 Apr 2010 at 1:56

GoogleCodeExporter commented 9 years ago
OK, it's a shame, IMHO these are very similar... :(

But never mind. I'm happily using another plugin with requested behavior :)

Original comment by mschayna on 29 Apr 2010 at 4:16

GoogleCodeExporter commented 9 years ago
Please consider adding an option to minimize on closing by Ctrl+W.

Original comment by Taras.Pu...@gmail.com on 11 Aug 2010 at 4:13

GoogleCodeExporter commented 9 years ago
Although this is tagged as a low priority enhancement, the behaviour described 
leads to a fairly serious bug.  The close button, last-tab close, or ctrl-W key 
are all allowed by FireTray (by design, I assume) to actually close the window 
rather than sending it to the tray.  Obviously not being able to ever reduce 
the number of windows could lead to problems :)

When the window that is closed is the one which instantiated FireTray, but 
other ones still remain, then the tray is left orphaned and the remaining 
windows are no longer fully under control.  I'm not sure quite what the status 
of FireTray is at that point since it doesn't detects mail events or control 
the remaining windows, but it still exists and intercepts some window actions.  
To reproduce in Thunderbird 3.1:

Close to Tray on
Minimise to Tray on

Start Thunderbird
Open a folder in a second window
Close the first window using the Thunderbird Close button or ctrl-W

The icon menu now no longer controls the Thunderbird window.  Likewise 
attempting to minimise or close the window does not send it to the tray.  It 
can still be closed using the Thunderbird Close or Quit menu items or commands 
and the tray icon will disappear shortly afterwards.

This behaviour is caused because FireTray is created on load of the first 
window, and within the scope of that window (messenger.xul).  Other windows can 
be detected and controlled, although actually they aren't completely as the 
code currently stands, but there is no way for the tray to continue to function 
when its containing window closes.  A possible solution would be to place the 
tray completely in an XPCOM singleton that would remain fully functioning 
whichever window was closed.  Perhaps another solution is to have a tray 
attached to every base window, but only one of them is visible at a time, 
although perhaps this would still require a singleton to co-ordinate 
everything?  I note that there is already a start at this containing the menu 
windows list.

Original comment by goo...@nartowicz.co.uk on 27 Sep 2010 at 8:52