foundation-model-stack / fms-acceleration

🚀 Collection of libraries used with fms-hf-tuning to accelerate fine-tuning and training of large models.
Apache License 2.0
0 stars 4 forks source link

Group Memory Field Names with Common Prefix #19

Closed achew010 closed 1 month ago

achew010 commented 1 month ago

Description

Comparison of the memory fields in the summary benchmarks is unintuitive.

Pandas sorts the fields in alphabetical order and because the memory tracking fields are not named with a common prefix in the current benchmarking code it ends up printing the report with memory values in columns far apart from each other in the table (see below image).

Proposed Solution

Renaming all memory values with a common mem_ prefix like the following

Update: Also remove the index column is introduced into the benchmark file.

This way when the results are gathered and exported to csv, the columns are grouped together intuitively for comparison.

fabianlim commented 1 month ago

@achew010 pls also note that the index column is introduced into the benchmark csv. Can we have this issue to also remove the index column?