search

foundation-model-stack / fms-hf-tuning

🚀 Collection of tuning recipes with HuggingFace SFTTrainer and PyTorch FSDP.
Apache License 2.0
22 stars 41 forks source link

bug: [Trainer controller] In trainer controller test cases, conditionals should use “is” instead of == #186

Closed seshapad closed 1 month ago

seshapad commented 3 months ago

Describe the bug

Trainer controller test cases are using the following conditional statement in assert:

    assert control.should_training_stop == True

Above statement needs to be changed to:

    assert control.should_training_stop is True

Platform

Please provide details about the environment you are using, including the following:

Sample Code

NA

Expected behavior

NA

Observed behavior

NA

Additional context

NA

anhuong commented 2 months ago

@seshapad can you provide more details and an example? Is this just for comparisons to None?

seshapad commented 1 month ago

@seshapad can you provide more details and an example? Is this just for comparisons to None?

@anhuong I have added details and an example.

seshapad commented 1 month ago

Addressed in PR #169.