Closed VassilisVassiliadis closed 5 days ago
@Ssukriti @anhuong This fix would really help the benchmarking effort as it removes the need for us to maintain a fork to work around it (and hence falling out of synch). Any help in getting it merged appreciated. :-)
LGTM. Thanks @VassilisVassiliadis I missed this check in my unit testing PR.
No problem!
@anhuong @Ssukriti @alex-jw-brooks Just a bump on this as we'd like to get rid of the need for a fork ASAP and this is just a single line change :-)
no worries!
Description of the change
Fixes a small bug in the method of train() sft_trainer.py where trainer_callbacks would append an array of user provided callbacks instead of concatenating the 2 arrays.
Without this change you get this exception:
Related issue number
Contributes to #142
How to verify the PR
Invoke the train() method with an
additional_callbacks
parameter that's an array containing at least 1 callback.Was the PR tested