Closed kpouget closed 1 week ago
I feel we should try to understand the root cause, because not allowing updates means not getting new fixes/features also.
I feel we should try to understand the root cause, because not allowing updates means not getting new fixes/features also.
definitely. This only allows the regression not to propagate this repo for the time being.
@kpouget can you share a simple repro script?
I feel we should try to understand the root cause, because not allowing updates means not getting new fixes/features also.
Also, without understanding the root cause, we cannot exclude this performance regression actually fixes an incorrect functional behavior.
@fabianlim I've updated the ticket https://github.com/foundation-model-stack/fms-hf-tuning/issues/201 description to include the steps to reproduce.
Hello, this PR appears not to work when we build the image, like if the requirements.txt
isn't followed. Could you please double check if that's the right way to pin the dependency?
Wrong place to make this update, should be in pyproject.yaml, this file is no longer used for package dependency versions or installation ack, I close this one
transformers >= 4.41
appears to create a performance regression in the fms-hf-training fine tuning jobs. This PR prevents the regression to happen in the fms-hf-tuning image by disallowing the installation oftransformers >= 4.41
, meaning thattransformers == 4.40
will be installed.This fix has been performance tested. It reverts the performance to the level prior to the publication of
transformers 4.41
with the regression![image](https://github.com/foundation-model-stack/fms-hf-tuning/assets/7559202/6603efa2-ef24-408c-a5bb-df3dd664324b)
with the fix![image](https://github.com/foundation-model-stack/fms-hf-tuning/assets/7559202/a57b010b-fc12-47b1-9eba-7ccf9c5e53bb)
See also: RHOAIENG-8551
Closes #201