foundation-model-stack / multi-nic-cni

https://foundation-model-stack.github.io/multi-nic-cni/
Apache License 2.0
33 stars 5 forks source link

change logger time encoder to ISO #101

Closed sunya-ch closed 1 year ago

sunya-ch commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Time encoder in latest release (v1.0.3), zapcore.RFC3339TimeEncoder, which is default value from controller runtime library, is not trivial to track the failure time in real world.

So, we should change it to ISO 8601 format.

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

sunya-ch commented 1 year ago

done by commit https://github.com/foundation-model-stack/multi-nic-cni/commit/3d8806a574abfd16668f71f18462732be668ed8d