foundation-model-stack / multi-nic-cni

https://foundation-model-stack.github.io/multi-nic-cni/
Apache License 2.0
33 stars 5 forks source link

cannot create net-attach-def resource when one of namespace failed to create/update #113

Closed sunya-ch closed 1 year ago

sunya-ch commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

When any of namespace is in terminating state which causing an error to create/update net-attach-def in that namespace, multi-nic-cni may not be able to continue updating net-attach-def for the other newly-created namespace due to that error.

https://github.com/foundation-model-stack/multi-nic-cni/blob/fba59cff7b7c320fcd12c712209303f0caa7f4ca/plugin/net_attach_def.go#L120-L131

To Reproduce Steps to reproduce the behavior:

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context Add any other context about the problem here.

sunya-ch commented 1 year ago

handled by https://github.com/foundation-model-stack/multi-nic-cni/pull/114