foundation-model-stack / multi-nic-cni

https://foundation-model-stack.github.io/multi-nic-cni/
Apache License 2.0
34 stars 5 forks source link

timely failed unit test 0 !=0 #57

Closed sunya-ch closed 1 year ago

sunya-ch commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

Observe the following unit test failure timely. Rerun the failed job works but need fixes.

To Reproduce Steps to reproduce the behavior:

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

• Failure [0.000 seconds]
[102](https://github.com/foundation-model-stack/multi-nic-cni/actions/runs/3956929573/jobs/6776696995#step:9:103)
Test Multi-NIC IPAM
[103](https://github.com/foundation-model-stack/multi-nic-cni/actions/runs/3956929573/jobs/6776696995#step:9:104)
/home/runner/work/multi-nic-cni/multi-nic-cni/controllers/multinicipam_test.go:62
[104](https://github.com/foundation-model-stack/multi-nic-cni/actions/runs/3956929573/jobs/6776696995#step:9:105)
  Dynamically compute CIDR [It]
[105](https://github.com/foundation-model-stack/multi-nic-cni/actions/runs/3956929573/jobs/6776696995#step:9:106)
  /home/runner/work/multi-nic-cni/multi-nic-cni/controllers/multinicipam_test.go:71
[106](https://github.com/foundation-model-stack/multi-nic-cni/actions/runs/3956929573/jobs/6776696995#step:9:107)

[107](https://github.com/foundation-model-stack/multi-nic-cni/actions/runs/3956929573/jobs/6776696995#step:9:108)
  Expected
[108](https://github.com/foundation-model-stack/multi-nic-cni/actions/runs/3956929573/jobs/6776696995#step:9:109)
      <int>: 0
[109](https://github.com/foundation-model-stack/multi-nic-cni/actions/runs/3956929573/jobs/6776696995#step:9:110)
  to be >
[110](https://github.com/foundation-model-stack/multi-nic-cni/actions/runs/3956929573/jobs/6776696995#step:9:111)
      <int>: 0
[111](https://github.com/foundation-model-stack/multi-nic-cni/actions/runs/3956929573/jobs/6776696995#step:9:112)

[112](https://github.com/foundation-model-stack/multi-nic-cni/actions/runs/3956929573/jobs/6776696995#step:9:113)
  /home/runner/work/multi-nic-cni/multi-nic-cni/controllers/multinicipam_test.go:38

https://github.com/foundation-model-stack/multi-nic-cni/blob/eb9c04826fa3863ebc86df27869940267cc07dec/controllers/multinicipam_test.go#L27-L38

Environment (please complete the following information):

Additional context Add any other context about the problem here.

Signed-off-by: Sunyanan Choochotkaew sunyanan.choochotkaew1@ibm.com

sunya-ch commented 1 year ago

May need to also check length of HostInterface snapshot.

https://github.com/foundation-model-stack/multi-nic-cni/blob/eb9c04826fa3863ebc86df27869940267cc07dec/controllers/multinicipam_test.go#L28

sunya-ch commented 1 year ago

should be fixed by https://github.com/foundation-model-stack/multi-nic-cni/pull/65