search

foundation / foundation-emails

Quickly create responsive HTML emails that work on any device and client. Even Outlook.
https://get.foundation/emails/docs/
MIT License
7.77k stars 1.09k forks source link

Zurb Email templates from demos use old code base #1039

Open DavvidJ opened 3 years ago

DavvidJ commented 3 years ago

How can we reproduce this bug?

Go to https://get.foundation/emails/email-templates.html and test demos templates

Testi it: https://testi.at/proj/xzPtAZjieryiboDCGwZUErLuo

also

https://testi.at/proj/BEVSXNjH1yYs8kRhnX6CLnb

What did you expect to happen?

Email should render better please update demos to use latest code fixes

What email clients does this happen in?

Outlook 2019 and a lot

DanielRuf commented 3 years ago

The templates can be found at https://github.com/foundation/foundation-marketing/tree/master/src/downloads/templates-emails

PRs are very welcome.

DavvidJ commented 3 years ago

and when you last time update update this samples : https://get.foundation/emails/templates/basic.html ?

DanielRuf commented 3 years ago

We have a CI setup which automatically builds and uploads the files after new commits are merged into the default branch. See also https://github.com/foundation/foundation-marketing/runs/961453002

DanielRuf commented 3 years ago

The file itself that you link has the following commit history: https://github.com/foundation/foundation-marketing/commits/master/src/downloads/templates-emails/basic.html

I'm currently not sure where they are built exactly (at least using inky). Normally this should be already the latest code. So something changed in the email clients. Or do you get the same result when using the latest version of foundation-emails.

Currently the whole setup is very confusing and hard to maintain. @joeworkman can probably provide more details regarding the Netlify setup.

Personally I have not much time to work on this and the other projects anymore.

DavvidJ commented 3 years ago

ok i will be compile it and compare