[The Grid] Collapse class on <row> not working in Inky

[maaarshallmooore]

How can we reproduce this bug? Assign 'collapse' class to element. You'll see that the nested remains padded. Write out the HTML (or Inky code) that causes the issue.

What did you expect to happen? Default padding to be removed from child elements of Inky's element. What happened instead? padding is being added to child elements of What email clients does this happen in? I've not tested this in a mail client, but it occurs while developing in the browser.

Here's the full list of dependencies if helpful: "dependencies": { "foundation-emails": "^2.2.1" }, "devDependencies": { "babel-core": "^6.3.26", "babel-preset-es2015": "^6.3.13", "babel-register": "^6.7.2", "beepbeep": "^1.2.0", "browser-sync": "^2.11.0", "colors": "^1.1.2", "gulp": "git+https://github.com/gulpjs/gulp.git#4.0", "gulp-awspublish": "^3.0.1", "gulp-cli": "^1.1.0", "gulp-html-src": "^1.0.0", "gulp-htmlmin": "^1.1.1", "gulp-if": "^2.0.0", "gulp-imagemin": "^2.4.0", "gulp-inline-css": "^3.0.0", "gulp-litmus": "0.0.7", "gulp-load-plugins": "^1.1.0", "gulp-mail": "^0.1.1", "gulp-rename": "^1.2.2", "gulp-replace": "^0.5.4", "gulp-sass": "^2.1.0", "gulp-sourcemaps": "^1.6.0", "gulp-uncss": "^1.0.1", "gulp-zip": "^3.2.0", "inky": "^1.3.6", "lazypipe": "^1.0.1", "merge-stream": "^1.0.0", "panini": "^1.3.0", "rimraf": "^2.3.3", "siphon-media-query": "^1.0.0", "yargs": "^4.1.0" }, "babel": { "presets": [ "es2015" ] }

[ghost]

Some import is not being done properly having a quick look a the code I can't seem to find where, copying the relevant bit of scss into app.scss works as a temporary workaround.

@for $i from 1 through $grid-column-count {
  //Collapsed logic
  .collapse {
    > tbody > tr > td.large-#{$i},
    > tbody > tr > th.large-#{$i} {
      padding-right: 0;
      padding-left: 0;
      width: -zf-grid-calc-px($i, $grid-column-count, $global-width) + $global-gutter;
    }

    //Gotta give it that extra love for the first and last columns.
    td.large-#{$i}.first,
    th.large-#{$i}.first,
    td.large-#{$i}.last,
    th.large-#{$i}.last {
      width: -zf-grid-calc-px($i, $grid-column-count, $global-width) + ($global-gutter * 1.5);
    }
  }
}

[kendallroth]

Has any progress been made on this? I've just noticed it as well, where the following code does not collapse or remove the padding on any child elements.

<container>
  <row class="collapse">
    <columns class="small-6">
      Test Column
    </columns>
    <columns class="small-6">
      Test Column
    </columns>
  </row>
</container>

[dompl]

Hiya,

Any progress on this?

Thanks

[adamlemmo]

I would also like to know if there is a solution to this issue.

And a general point, is there any information from Foundation about this? I'm not seeing a lot of activity from them in 2019! Is it still a thing?

[st-h]

And a general point, is there any information frm Foundation about this? I'm not seeing a lot of activity from them in 2019! Is it still a thing?

@adamlemmo there is quite some info available scattered throughout various issues regarding that matter. If you have a look at the code, you will notice that there hasn't been any development for 2 years. There are still people around here who state that this project is still alive - however it turned out that there actually seems to be nobody who actually has the necessary permissions to make any changes to the actual code.

[adamlemmo]

And a general point, is there any information frm Foundation about this? I'm not seeing a lot of activity from them in 2019! Is it still a thing?

@adamlemmo there is quite some info available scattered throughout various issues regarding that matter. If you have a look at the code, you will notice that there hasn't been any development for 2 years. There are still people around here who state that this project is still alive - however it turned out that there actually seems to be nobody who actually has the necessary permissions to make any changes to the actual code.

Thanks for the reply, but thats a sad state of affairs :(

Are there any other active projects that come close to what Foundation for Emails is/was doing? Are there alternatives?

[st-h]

@adamlemmo mjml is the only alternative that I am aware of. If you find anything else worth mentioning, I would appreciate if you could let us know. Yeah, it's quite sad, since all we need would be somebody with write access who would be able to merge a couple of PRs that at least would fix some basic issues - but well, it took me quite some time to find out that there is no one who would be able to make actual changes to this repo, mostly because some people claim that this project is still doing great.