search

foundation / foundation-rails

Foundation for Rails
foundation.zurb.com
MIT License
1k stars 376 forks source link

update to sassc-rails #287

Closed chnikki closed 3 weeks ago

chnikki commented 4 years ago

Keep getting the sass eol error when running bundle install. The sass gem reached end of life March 26, 2019. This change is switching to use sassc-rails, which uses the new C implementation of Sass as requested in issue #278. I also added rails 6.0 to the appraisal test.

javierjulio commented 4 years ago

@cparker-ajla thanks! Now we are getting a different error. I think the problem may be related to the gemspec path and gemfiles based on what I look up for that error message. Here is a sample error from one of the builds:

You are trying to install in deployment mode after changing
your Gemfile. Run `bundle install` elsewhere and add the
updated gemfiles/rails_5.0.gemfile.lock to version control.

The gemspecs for path gems changed
javierjulio commented 4 years ago

No problem! Thanks for tackling this. Let me know if you have an update and/or need help. I'm not familiar with appraisals so I'm not sure why the builds are failing. The the lock files in /gemfiles don't look right though so I'm thinking something went wrong with updating them perhaps?