search

foundation / foundation-rails

Foundation for Rails
foundation.zurb.com
MIT License
1k stars 375 forks source link

Fix: Deprecation warning on sass #298

Open nbw opened 4 years ago

nbw commented 4 years ago

Summary

Fixes some deprecation warnings that have recently popped up.

13:12:13 rails.1   | DEPRECATION WARNING on line 115 of /usr/local/Cellar/tmuxinator/2.0.0/libexec/gems/foundation-rails-6.6.2.0/vendor/assets/scss/util/_color.scss:
13:12:13 rails.1   | !global assignments won't be able to declare new variables in future versions.
13:12:13 rails.1   | Consider adding `$primary-color: null` at the top level.
13:12:13 rails.1   |
13:12:13 rails.1   | DEPRECATION WARNING on line 120 of /usr/local/Cellar/tmuxinator/2.0.0/libexec/gems/foundation-rails-6.6.2.0/vendor/assets/scss/util/_color.scss:
13:12:13 rails.1   | !global assignments won't be able to declare new variables in future versions.
13:12:13 rails.1   | Consider adding `$secondary-color: null` at the top level.
13:12:13 rails.1   |
13:12:13 rails.1   | DEPRECATION WARNING on line 125 of /usr/local/Cellar/tmuxinator/2.0.0/libexec/gems/foundation-rails-6.6.2.0/vendor/assets/scss/util/_color.scss:
13:12:13 rails.1   | !global assignments won't be able to declare new variables in future versions.
13:12:13 rails.1   | Consider adding `$success-color: null` at the top level.
13:12:13 rails.1   |
13:12:13 rails.1   | DEPRECATION WARNING on line 130 of /usr/local/Cellar/tmuxinator/2.0.0/libexec/gems/foundation-rails-6.6.2.0/vendor/assets/scss/util/_color.scss:
13:12:13 rails.1   | !global assignments won't be able to declare new variables in future versions.
13:12:13 rails.1   | Consider adding `$warning-color: null` at the top level.
13:12:13 rails.1   |
13:12:13 rails.1   | DEPRECATION WARNING on line 135 of /usr/local/Cellar/tmuxinator/2.0.0/libexec/gems/foundation-rails-6.6.2.0/vendor/assets/scss/util/_color.scss:
13:12:13 rails.1   | !global assignments won't be able to declare new variables in future versions.
13:12:13 rails.1   | Consider adding `$alert-color: null` at the top level.
13:12:13 rails.1   |
13:12:13 rails.1   | DEPRECATION WARNING on line 164 of /usr/local/Cellar/tmuxinator/2.0.0/libexec/gems/foundation-rails-6.6.2.0/vendor/assets/scss/util/_breakpoint.scss:
13:12:13 rails.1   | !global assignments won't be able to declare new variables in future versions.
13:12:13 rails.1   | Consider adding `$-zf-size: null` at the top level.
13:12:13 rails.1   |
13:12:13 rails.1   | DEPRECATION WARNING on line 369 of /usr/local/Cellar/tmuxinator/2.0.0/libexec/gems/foundation-rails-6.6.2.0/vendor/assets/scss/util/_mixins.scss:
13:12:13 rails.1   | !global assignments won't be able to declare new variables in future versions.
13:12:13 rails.1   | Consider adding `$-zf-bp-value: null` at the top level.
13:12:13 rails.1   |
ckorhonen commented 3 years ago

Any chance of getting this merged? Would love to get rid of these warnings!

PhilippeBo commented 3 years ago

Any update about this PR ?

alecslupu commented 3 years ago

Do we have any updates on this PR ?

mrcasals commented 3 years ago

@joeworkman hi! Any chance this could be merged? Tests are failing in master branch with the same error...

lapser commented 1 year ago

Any update about this PR? Maybe a problem related to the button-group class is caused by one of these warnings.

Screenshot 2023-03-01 at 23 13 36