search

foundation / foundation-rails

Foundation for Rails
foundation.zurb.com
MIT License
1k stars 376 forks source link

Sass(c) compilation failure #789

Open tlbraams opened 3 weeks ago

tlbraams commented 3 weeks ago

Hi, our asset pipeline failed when we tried to upgrade to the latest version (6.9.0.0) with the following error:

SassC::SyntaxError: Error: Invalid CSS after "    @return math": expected expression (e.g. 1px, bold), was ".abs($a);" (SassC::SyntaxError)

Investigating this failure led me to discover that this version introduced the use of '@use {x};' in the scss files. This syntax is only supported by dartsass and not libsass/rubysass. https://sass-lang.com/documentation/modules/

afbeelding

The (unreleased) update to 6.7.5 updated the gemspec to use the sassc gem instead of the sass. The now deprecated sass gem uses rubysass while sassc uses libsass. The update to 6.9.0.0 did not include a change to the dependencies indicating that the project now requires dartsass.

Was this an intentional change where a dependency update was missed or were you not aware that this syntax was not compatible with libsass?

ayaman commented 3 weeks ago

I think this was unintentional and is simply a case of a missed dependency update. I created a pull request to fix this.