Mixins that change input background color should use "background-color" instead of "background" property

foundation / foundation-sites

The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.

https://get.foundation

MIT License

29.66k stars 5.48k forks source link

Mixins that change input background color should use "background-color" instead of "background" property #2307

Closed ppadron closed 11 years ago

ppadron commented 11 years ago

If you set a background-image to an input field, it is overriden by background declarations in some form-related mixins, like this one: https://github.com/zurb/foundation/blob/master/scss/foundation/components/_forms.scss#L106

I believe they should be changed from background to background-color, since that's the only property they are changing. What do you think? I can make a patch and submit a pull request if you agree.

Thanks, Pedro Padron

hatefulcrawdad commented 11 years ago

Yeah, I agree. Make a patch and submit it :)