search

foundation / foundation-sites

The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.
https://get.foundation
MIT License
29.65k stars 5.48k forks source link

Vertical Rhythm is all guesswork it seems #2776

Closed nijikokun closed 10 years ago

nijikokun commented 11 years ago

Especially the part where you set the margins of headers to be either equal or unequal in the incorrect direction (larger bottom margin than top). Usually the header is attached to the paragraph or evenly margined / line-heighted rather than attached to the area above when put near a bordered element.

Here is an example of what I am saying, and this is the default:

[BORDERED ELEMENT] HEADER

CONTENT

It should be by default:

[BORDERED ELEMENT]

HEADER CONTENT

We shouldn't be required to add markup or styling to fix the default aesthetics and vertical rhythm.

alokjethanandani commented 11 years ago

@Nijikokun hey im alok from zurb. can you please share a screenshot or a link to the example that's causing problems. is this a change you wish to make to foundation defaults or is this just something that's throwing you off? from what i understand you're uncomfortable with inconsistent top and bottom margins on heading and paragraph elements.

vinayraghu commented 11 years ago

@Nijikokun a screenshot would explain better. But in general, I would agree that it would be a great idea to have all bottom/top margins or line-heights to be multiples of a single variable to maintain standards in terms of spacing.

@alokzurb is it possible that the current bottom and top margins are already calculated based on some scale?

cmwinters commented 10 years ago

This has been improved in F5, and noted in #3100, so I'm closing this for now