search

foundation / foundation-sites

The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.
https://get.foundation
MIT License
29.65k stars 5.49k forks source link

Sass version gitignore hides /stylesheets/* and /bower_components/* #4306

Closed ryanburnett closed 10 years ago

ryanburnett commented 10 years ago

Why does the Foundation 5 Sass version have:

/bower_components/*
/stylesheets/*

in .gitignore?

Both of these directories are required if you want your css and js to load.

Shouldn't these lines be removed from .gitignore?

KraigWalker commented 10 years ago

Given that stylesheets are generated from sass & bower_components is populated by bower_install - I think the psychology of the decision is to prevent your foundation project being polluted by tweaks and changes to third party components.

If you're using github pages to host your site, or a similar git-based push methodology, then yes, you'll need to remove them from the gitignore so that all the dependencies are included.

Or you could configure git in such a way that making a push to a specific branch or source would invoke the inclusion of the generated stylesheets and bower components. It's cleaner from a project management point of view to look into that (take a look at dotfiles and customising your .gitconfig file with custom alias commands) especially if you're working with multiple co-workers.

rafibomb commented 10 years ago

@KraigWalker Thanks for helping with the explanation!