search

foundation / foundation-sites

The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.
https://get.foundation
MIT License
29.66k stars 5.48k forks source link

Button Hover and Border variables #5455

Closed rlafranchi closed 9 years ago

rlafranchi commented 10 years ago

I would like to add button and hover variables and have worked on the code below, but need someone to review and verify that it works properly.

https://github.com/rlafranchi/foundation/blob/c3f8d81e1812ed341b3b31fa93655f365a50c5b0/scss/foundation/components/_buttons.scss

elvijsuntals commented 10 years ago

Thanks!

ctalkington commented 10 years ago

I believe this is the better way of handling button hovers.

ctalkington commented 10 years ago

that said there appears to be some un-needed code in your commit.

if $bgh-lightness > 70% sections need review.

gakimball commented 9 years ago

Those variables made it in with this commit: 652526a06343940f7bfe996ef66d3d507a3fa2e3