foundation / foundation-sites

The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.
https://get.foundation
MIT License
29.65k stars 5.48k forks source link

The Split button does not work. #636

Closed saidbakr closed 12 years ago

saidbakr commented 12 years ago

The split button does not work when an anchor found in the url or after a redirect from another page with query strings, for example: http://quran.2index.net/socials/facebook#done a split button is found at the page bottom and next to the Facebook icon.

Also to approve that it is a bug in Foundation 3.0 please try to visit the foundations official documentation from the following URL http://foundation.zurb.com/docs/buttons.php/#58 and check both split button and dropdown button you will them does not work.

saidbakr commented 12 years ago

I don't know why this issue is not followed and recorded by the development team?!

jtammen commented 12 years ago

Hi Said,

http://quran.2index.net/socials/facebook#done

I'm seeing a script error on that page: app.js:33: Uncaught TypeError: Cannot read property 'customForms' of undefined. That results in following script parts not being executed. You should fix that error first – in this case, there is some code for dealing with tabs when there is a hash fragment present, maybe you don't need that at all.

http://foundation.zurb.com/docs/buttons.php/#58

That problem on ZURB's page does not seem to have anything to do with the hash fragment in the URL but rather the trailing slash: just leave the hash out and keep the slash at the end – the split buttons still don't work. Seems to be some relative path problem, as the file marketing_docs.js does not exist under /docs/public/assets...

HTH and greets, Jan.

saidbakr commented 12 years ago

Hi Jan. Removing the hash from the URL will solve the issue, which means that there is something wrong in Foundation not my script or Zurb's official documentation script!.

I believe that Foundation 3.0 has a bug somewhere! Any web page is probably accessed by redirects with hash!

jtammen commented 12 years ago

Hi Said,

I cannot confirm that. For me (Chrome on Mac),

The problem you encounter seems to come from app.js, line 33, where there is some stuff for custom forms. Are you using the app.js file from Foundation 2 together with F3?

Best greets, Jan.

mhayes commented 12 years ago

Can't reproduce this particular issue with the latest build of Foundation (3.0.9). I agree with @jtammen about checking app.js to make sure that it wasn't ported over directly from Foundation 2. Cheers!

saidbakr commented 12 years ago

Hi, Do you see any problem on Foundation official website http://foundation.zurb.com/docs/buttons.php/#58 using FireFox 14.0.1?

EnigmaSolved commented 12 years ago

http://foundation.zurb.com/docs/buttons.php#test works fine for me using Firefox 14.0.1. Both the split button and drop down work fine.