Custom Download for F6 - Issues...

[LDigital84]

From what I can tell there isn't a way to select and use the Flexbox grid if you use the Custom Download tool.

Am I missing something and there is there a way to do this?

If not, this option needs to be available.

List of issues with the Customizer and Customizer Page:

• [x] No way to select Flexbox Grid
• [x] Error in the console saying jQuery is not defined. (In Firefox, Chrome does not throw a jQuery error.)
• [x] JS Error: SyntaxError: function statement requires a name templates.js:1:8
• [x] The max-width is set to 62.5rem on the customizer page, however, the download max-width is 75rem. Colors are also different.
• [x] The link at the top of the page (in the top bar) for Docs is broken on the customizer page.
• [x] In the foundation.js (and min.js) file the version is listed as 6.0.0-alpha.1.
• [x] In the foundation.js (and min.js) file the version is 6.0.1. Should be 6.0.4.
• [x] When I unzip (using 7zip) the custom download I see this error: Data error in 'custom-f6\app.css'. File is broken. Other files appear okay.
• [x] If you select the Flex Grid and no other items, the customizer only downloads the normalize CSS and nothing else.
• [x] Some downloads are missing foundation.css #7520 #7702
• [x] Gutter size can't be changed #7593
• [x] Essentials missing the grid #7753
• [x] Selecting "No Grid" results in a missing foundation.css file #7819
• [x] Add field to change $warning-color #7858
• [ ] Checkbox state can go out of whack when manipulating the "All Foundation Components" checkbox #7820
• [x] 7 digits can be entered into the color fields #8061

[erikmellum]

@Benboe given the imminent release of version 6.20, I am going to hold off on the gutter changes. Once 6.20 releases next week it should be configurable once again. Apologies for any inconvenience that may cause.

[benvanlooy]

@erikmellum thanks for the info!

Do you have a specific date when everything will work again? I can't possibly imagine that I'm the only one who frequently uses the custom settings?

I don't know if it helps, but I added a screenshot of the settings I enter that make the download break.

[erikmellum]

@Benboe it looks like both your success and alert color are using only 5 characters which will break the downloader. Other than that, I tried your settings and they seem to work.

I am hoping the issue with gutter will be fixed by the end of the weekend.

[gakimball]

@erikmellum For the gutter stuff:

$grid-column-gutter is now the only way to set gutters. It accepts either a single numeric value, or a map. So for the customizer, you can pass it a number and everything will work fine.

[benvanlooy]

@erikmellum ouch! sorry man!! that's so stupid of me, that'll teach me to copy paste the colour code without double-checking

thanks again so much for your hard work!! really appreciate it!

[LDigital84]

@erikmellum @gakimball - Any idea on when this may work again? I'm not trying to be a bother. Just curious. Thank you for all you do!

[benvanlooy]

First of all @erikmellum thanks so much for this great project :-)

Having said that, I'm about to start some new projects and I really would need the custom downloads as I really wanna use foundation.

Is there an estimate of when this will work again?

[erikmellum]

Hello all,

Sadly I don't have an estimate for when the customizer will be fixed. My license for VMWare expired, which is what I was using to maintain the customizer. I will be doing my best to set up a new VM dev environment using virtualbox, but I'm unsure when that will be completed. ZURB is working towards a solution so I will defer further questions to @gakimball.

[LDigital84]

@erikmellum - Thank you for the info. I think ZURB should buy you a new license for VMWare. :smiley:

[benvanlooy]

I agree ^_¨

But from what I've seen the last months however, sometimes I have a feeling Foundation is coming to an end, I hope I'm wrong here.. It's just a feeling I have..

The custom download has been very very unstable the last months and now even just not available anymore since quite a while. And (perhaps I'm doing something wrong?) but I can't get the accordion to work out of the box, also when I download the full package (which is the only choice now), it doesn't include all the seperate .js-files anymore (like accordion).

It looks like ZURB doesn't really care that much anymore? :-(

[rafibomb]

Totally hear you about the customizer! It's been unreliable since we launched F6 and recently broke when 6.2 was released. It is requiring a re-build which is what we're working on now. We are planning to have it squared away by the end of the month.

@Benboe As far as the accordion issue you mentioned, if there is already an open issue for it we'd like to see it for the next release.

[gakimball]

Hey friends! Thanks for your patience. We've been weighing some options about how to stabilize the customizer, and we've arrived at a solution. We plan on having it done in the next week or so.

We're also letting @erikmellum off the hook :) He's been gracious enough to donate his time to the customizer, but he's no longer contracting with us. So you can direct all customizer issues to myself, @rafibomb, and @kball.

If you want to see the updates for yourself, we have an open pull request with custom builds working: #8400

[LDigital84]

@gakimball - Thank you for the update! Glad to hear it.

@erikmellum - You rock for the time you donated to help us that use Foundation and love the customizer!

[LDigital84]

@kball @gakimball

I saw that #8400 was merged and the customizer is working again. Thank You!

Couple things I noticed:

1) Vendor prefixes are missing.

2) It appears flex properties are used, even if the normal grid is selected.

[kball]

Hi @Lynda333,

Thanks for taking a look!

Looking at the normal grid selection, it looks like what's getting set still is the flex-basis on a number of classes, but display:flex etc are not. Can you confirm this is what you're seeing? @gakimball is that intended or unexpected?

On the vendor prefixes, @gakimball can you take a look at that? It looks like maybe autoprefixer isn't in the customizer build pipeline?

[ghost]

Thanks for the amazing work!

[LDigital84]

@kball - Yes, that is what I'm seeing.

[ghost]

@kball @gakimball

Btw, got an error when creating a new instance of an off-canvas wrapper (No errors at full download). "Uncaught TypeError: Foundation.OffCanvas is not a constructor"

var ofc = new Foundation.OffCanvas($('#newOffcanvas'), {forceTop: false});

[kball]

@Silvester20 Can you link to the page in question somewhere I can take a look? I tried a complete download just now and had no issues instantiating a new offcanvas.

[ghost]

You shouldn't do a complete download,instead, download package from custom download, set up a off canvas in html and create an instance to it via js/jquery.

Btw, it would be nice to minify the included jquery file.

[LDigital84]

@kball @gakimball @rafibomb - Any updates on the customizer? Still seeing the same problems.

[ghost]

@kball About the Off Canvas check http://foundation.zurb.com/forum/posts/39376-off-canvas-missing-in-customized-js

[rafibomb]

Couple things appear to be fixed by @kball ! Fixed off-canvas not included with custom flex grid, fixed pagination not included in customizer.

[kball]

I believe I also fixed the flex & prefix issues reported by @Lynda333

[LDigital84]

@kball @rafibomb - Thank you! From what I see all appears fixed. If I run into any problems, I'll post them. :)

[karls77]

@kball @gakimball I still see no pagination class included in the css in the customizer. The menu-icon class is also missing from the css. But it's also serving up 6.2.0 and not 6.2.1 according to the comments in the css and js. Edit to add: I just tried the custom download eight times. I received 6.2.1 seven times and 6.2.0 once. Tried different settings but couldn't find any combination that would consistently cause this to happen.

[LDigital84]

@karls77 - I just tried the download and I am seeing 6.2.1 in the comments as well as pagination classes and menu-icon classes in the CSS.

[ghost]

Seems off canvas is working too now, thanks!

[colin-marshall]

A user has reported issues with menu-icon in the custom and complete downloads. https://github.com/zurb/foundation-sites/issues/8565

[joomlolo]

hello, Always the problem with "Choose Your Components:" "All Foundation Components" checking or uncheking don't work and another thing more important some flex settings are added to the grid even if flexbox is not selected,the same in the sass version

https://github.com/zurb/foundation-sites/issues/8501

[benvanlooy]

Is it "normal" that the tabs still don't seem to work? :-o

I custom downloaded, left all the boxes checked, I used the tabs code.. and it doesn't work.. I also see no plugins such as accordion in the vendor directory?

[colin-marshall]

@Benboe I cannot reproduce your issue. I just went to the customizer page, left everything selected as is, and downloaded. I added tabs code to index.html and they worked. What markup did you use for the tabs? Any errors in the console?

I don't think you're supposed to get the individual plugins in the vendor directory. The JS components you select in the customizer get concatenated into foundation.js and foundation.min.js.

[colin-marshall]

@JTallis I fixed the menu-icon class issue with #8608. I'm not totally sure when that will go into effect on the website. @kball?

[benvanlooy]

@colin-marshall my bad! I think i was using old foundation5 code, it changed :-) thanks for checking!

But... it might be me.. but it seems can't enter any numeric values on the custom download page (for the 3 grid values)?

I'm using a macbook pro, tried with firefox and chrome..

the only work around is using firebug, updating the values that way

[LDigital84]

@Benboe - Changing the values works for me on Firefox and Chrome (using Windows 10).

[colin-marshall]

@kball: If I download only the flex-grid in the customizer with everything else unchecked I get the animation classes too. Is this a customizer bug or do these come standard in every customizer download? See #8806.

[kball]

@colin-marshall good question. Looking at the template being used, it appears motion-ui transitions and animations are currently always being included, so this appears to be the intent. I'm not sure why - this seems like something that should be optional - So we could accept a PR that moved those from being a standard part of the template (see SASS_TEMPLATE variable in customizer/lib/sass.js) and into something configurable... we'd also need to change the UI in the customizer web app itself to handle this.

[rafibomb]

@kball @colin-marshall When F6 was released and customizer setup, Motion-ui was a dependency of many components. It may be optional now as Orbit can operate without it.

[webuxr]

@LDigital84 - Seems like the only remaining unchecked box in your original post is now complete (#7820 marked closed). Does this mean #7033 can also be closed?

There’s an a lot of great work in this ticket and I think it would be awesome to see #7033 closed as well.

That is, if the original issue with Foundation download page/options/checkboxes, et. al. have been addressed.

[JeremyEnglert]

All issues here have been addressed. Closing.