search

foundation / foundation-sites

The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.
https://get.foundation
MIT License
29.67k stars 5.48k forks source link

Custom Dropdown Value Issue (new) #715

Closed jd19007 closed 12 years ago

jd19007 commented 12 years ago

line 345-347 shouldn't it be

if ($currentSelect) { $currentSelect.html( $( this ).html() ); }

instead of

if ($currentSelect) { $currentSelect.html( this.value ); }

So that it will get the html value and not the value by default?

jd19007 commented 12 years ago

Line number may be wrong due to I pasted it in my app.js with some changes.

alettieri commented 12 years ago

Yup @jondavis0787, updated and pushed the fix. Thanks!

alettieri commented 12 years ago

@smileyj68 @mrsweaters this can be closed.

elidupuis commented 12 years ago

I just pulled the newest version of the customForms plugin (with this fix applied) and I still seem to be getting the value attribute of the option instead of the .html(). Is there anything else related to this that I need to update?