search

foundation / foundation-sites

The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.
https://get.foundation
MIT License
29.66k stars 5.49k forks source link

Upgrade error #831

Closed roywblack closed 11 years ago

roywblack commented 12 years ago

compass install -r zurb-foundation foundation/upgrade --force identical images/foundation/orbit/rotator-black.png identical images/foundation/orbit/right-arrow.png identical images/foundation/orbit/pause-black.png identical images/foundation/orbit/timer-black.png identical images/foundation/orbit/bullets.jpg identical images/foundation/orbit/right-arrow-small.png identical images/foundation/orbit/left-arrow.png identical images/foundation/orbit/mask-black.png identical images/foundation/orbit/left-arrow-small.png identical images/foundation/orbit/loading.gif identical javascripts/foundation/jquery.placeholder.js overwrite javascripts/foundation/jquery.foundation.tabs.js create javascripts/foundation/jquery.offcanvas.js overwrite javascripts/foundation/jquery.foundation.forms.js identical javascripts/foundation/jquery.foundation.tooltips.js identical javascripts/foundation/modernizr.foundation.js create javascripts/foundation/jquery.foundation.mediaQueryToggle.js overwrite javascripts/foundation/jquery.foundation.reveal.js overwrite javascripts/foundation/jquery.foundation.navigation.js overwrite javascripts/foundation/jquery.foundation.accordion.js identical javascripts/foundation/jquery.foundation.alerts.js create javascripts/foundation/jquery.js overwrite javascripts/foundation/jquery.foundation.buttons.js overwrite javascripts/foundation/jquery.foundation.orbit.js error sass/app.scss (Line of modular-scale.scss: An @import loop has been found: /home/roy/.rvm/gems/ruby-1.9.3-p194/gems/zurb-foundation-3.0.9/scss/foundation/functions/modular-scale.scss imports itself) overwrite stylesheets/app.css

hatefulcrawdad commented 12 years ago

Are you still seeing this issue? What version were you upgrading from?

roywblack commented 12 years ago

Yes. I was upgrading from 3.0.7. It says the assets were all upgraded successfully but I get the same error when I run compass compile in the upgraded directory. I'm guessing the following is the problem


diff -r foundation/sass/_settings.scss foundation309/sass/_settings.scss
1c1
< @import "foundation/functions/modular-scale";
---
> @import "foundation/common/ratios";

But I thought upgrade was supposed to overwrite this file.

hatefulcrawdad commented 12 years ago

Ah, 3.0.7 was an odd child out. You can get rid of the 'foundation-styles' folder and references. Then just reference app.css in the head of your page. Also update your @import: "foundation/base": to @import: "foundation";

hatefulcrawdad commented 12 years ago

Did you get this fixed? I want to make sure you are able to use Foundation successfully.

roywblack commented 12 years ago

I am currently still using 3.0.7. I will try to update to the latest version some time this week.

hatefulcrawdad commented 11 years ago

Any luck with this?

hatefulcrawdad commented 11 years ago

I'm going to close this down for now. Let me know if you are still experiencing the issues with the latest version and I'll reopen, thanks!