search

foundation / inky-rb

MIT License
173 stars 33 forks source link

fix components config #100

Closed SampsonCrowley closed 5 years ago

SampsonCrowley commented 5 years ago

fixes config to actually allow setting components tags as mentioned in README.md

fixes config error portion of issue #95

SampsonCrowley commented 5 years ago

@marcandre made a few tweaks based on your feedback, but left most of the possibly redundant testing in.

I'm of the opinion that it's better to "over-test" than to under do it. These scenarios were just the best way i could think of to triple check that I was testing exactly what I was expecting. I am more than willing to modify as needed though

marcandre commented 5 years ago

Excellent work 🙇

marcandre commented 5 years ago

BTW, the convention in Ruby is to use only implicit conversion (to_hash, to_int, ...); there are very few exceptions to this in the core language (e.g. puts/p).

SampsonCrowley commented 5 years ago

Excellent point. Thanks for all the feedback!