search

foundation / inky-rb

MIT License
173 stars 33 forks source link

Rails 7 support? #109

Open aforty opened 1 year ago

aforty commented 1 year ago

I just updated to rails 7 and I can't seem to get this to load. It looks like it never registers the inky extension. Has anyone gotten this to work?

daniel-rikowski commented 1 year ago

I'm using Inky with Rails 7 and Ruby 3.1 on Windows and Alma Linux.

I do use a simple monkey patch to remove layout breaking whitespace from the generated HTML, but this is for an Inky bug, and not related to the Rails version.

randombrick commented 1 year ago

I just updated to rails 7 and I can't seem to get this to load. It looks like it never registers the inky extension. Has anyone gotten this to work?

same 4 me

phoet commented 1 year ago

looks like its completely gone with rails 7.1

inky-rb-1.4.2.0/lib/inky.rb:38:in `release_the_kraken'

NoMethodError:

undefined method `gsub' for #<ActionView::OutputBuffer

zealot128 commented 1 year ago

I've made a simple change, it seems to work with Rails 7.1.beta1 now:

https://github.com/foundation/inky-rb/pull/110