Closed davidpustai closed 1 year ago
@rafibomb Still maintaining this repo in some way? Or is someone else? What do I have to do to get this moving?
I know the tests are failing, but they are at least partially failing because of last commit to v2.2
, which is failing too. I was trying to fix it, but couldn't get my head around it. :baby:
Checks failing due to repo owner name change. Could you restart the build of this PR? cc @garyanikin
Checks failing due to repo owner name change. Could you restart the build of this PR? cc @garyanikin
I will rebase your PR so the CI changes are reflected.
It seems there are several conflicts. Please check and resolve them.
Just bumping this PR because I think it's very important for accessibility! I'm currently using a hacky solution myself in light of this not being the default.
@nasiscoe — Curious, what is your hacky solution? Agree that merging this PR would be an easy win for accessibility.
@nasiscoe — Curious, what is your hacky solution? Agree that merging this PR would be an easy win for accessibility.
I just used a grep command in my build pipeline to manually add role presentation to all built email templates inside the table
tag - not as elegant as it being supported out of the box :)
Problem
The tables in Inky's generated HTML are purely for styling purposes. For someone using a screen reader it gets really messy to understand the email (video demo).
Solution
Just add the WAI-ARIA
role="presentation"
to all the generated<table>
s.Solves
https://github.com/zurb/foundation-emails/issues/728
Resources
http://blog.gorebel.com/accessibility-in-email-part-ii/ https://css-tricks.com/html-email-accessibility/#article-header-id-0