Open SampsonCrowley opened 5 years ago
@tdhartwick what should I do if the current develop
branch already has failing tests before I even start working? just ignore them and keep the pull request under SRP (only one feature change per request?)
@marcandre which branch should I actually be targeting here? v2
is the most recently updated, develop
is the most recent not v*
branch, and master hasn't been updated for 3 years
You should target develop
. Note that I'm not a committer on inky
; I'm not sure who the current maintainers are.
My mistake; I thought I had seen your name on a merge in this repo as well
since this is an HTML based library, I found this functionality to be extremely surprising. I will submit a PR to fix as soon as I can
input
expected
output