search

foundation / inky

Convert a simple HTML syntax into tables compatible with Foundation for Emails.
http://foundation.zurb.com/emails
673 stars 107 forks source link

<raw> tags don't support multi-line html #109

Open SampsonCrowley opened 5 years ago

SampsonCrowley commented 5 years ago

since this is an HTML based library, I found this functionality to be extremely surprising. I will submit a PR to fix as soon as I can

input

<body>
  <raw>
    <<LCG ProgramTG LCG Coupon Code Default='246996'>>
    <button>
  </raw>
</body>

expected

<body>
    <<LCG ProgramTG LCG Coupon Code Default='246996'>>
    <button>
</body>

output

<body>
  <raw>
    <<lcg programtg lcg coupon code default="246996">>
      <table class="button">
        <tbody>
          <tr>
            <td>
              <table>
                <tbody>
                  <tr>
                    <td>
                      </td>
                  </tr>
                </tbody>
              </table>
            </td>
          </tr>
        </tbody>
      </table>
      </lcg>
  </raw>
</body>
SampsonCrowley commented 5 years ago

@tdhartwick what should I do if the current develop branch already has failing tests before I even start working? just ignore them and keep the pull request under SRP (only one feature change per request?)

SampsonCrowley commented 5 years ago

@marcandre which branch should I actually be targeting here? v2 is the most recently updated, develop is the most recent not v* branch, and master hasn't been updated for 3 years

marcandre commented 5 years ago

You should target develop. Note that I'm not a committer on inky; I'm not sure who the current maintainers are.

SampsonCrowley commented 5 years ago

My mistake; I thought I had seen your name on a merge in this repo as well