search

foundation / inky

Convert a simple HTML syntax into tables compatible with Foundation for Emails.
http://foundation.zurb.com/emails
673 stars 107 forks source link

Change cheerio version to stable #126

Open lisunovdv opened 3 years ago

lisunovdv commented 3 years ago

cheerio v0.20.0 or v1.0.0-rc.5 parses incorectly custom self-closing XML tags, e.g:

<isinclude template="checkout/confirmation/confirmationEmail"/>

will become

<isinclude template="checkout/confirmation/confirmationEmail"/></isinclude>

And cheerio option recognizeSelfClosing: false can't help.

It's fixed only in the stable release of "cheerio" - v0.22.0 (that is used in inline-css

But v1.0.0-rc.5 has alatest tag so we need to write "cheerio": "0.22.0"' instead of"cheerio": "^0.22.0"`

DanielRuf commented 3 years ago

Hi @lisunovdv,

thanks for your PR.

But v1.0.0-rc.5 has alatest tag so we need to write "cheerio": "0.22.0"' instead of"cheerio": "^0.22.0"`

This is not correct. The SemVer range "^0.22.0" uses only 0.22.x, see:

Bildschirmfoto 2021-01-24 um 14 50 48 Bildschirmfoto 2021-01-24 um 14 53 35

We should not pin the version to get security updates.