search

foundation / inky

Convert a simple HTML syntax into tables compatible with Foundation for Emails.
http://foundation.zurb.com/emails
674 stars 108 forks source link

Don't added first/last classes if they already exist #82

Closed danherd closed 2 years ago

danherd commented 7 years ago

Fix issue where first/last classes are added even if they already exist in an element.

This fixes https://github.com/zurb/foundation-emails/issues/760

rafibomb commented 7 years ago

Thanks for the PR

I think Inky should swap the classes .first and .last for us when it sees dir="rtl"

And I think that dir at that point can be changed to something else like order="2" (and in the HTML does dir="rtl") and Inky will parse the .last class onto that column. This will fix the column padding issue too, right?

wallacio commented 6 years ago

This would be a really usefu PR to merge, and make source ordering a noteable feature.

@rafibomb I agree; some kind of interpretation of dir would probably be more correct but I can see why explicitly setting first/class on columns would be preferable in some cases.

@danherd Are you still working on this or will I open a new PR?