search

foundation / motion-ui

💎 The powerful Sass library for creating CSS transitions and animations
https://zurb.com/playground/motion-ui
MIT License
1.15k stars 175 forks source link

chore: move jQuery to peerDependencies #116

Closed ncoden closed 6 years ago

ncoden commented 6 years ago

Description

Move jquery from dependencies to peerDependencies.

Motivation and Context

peerDependencies is for dependencies that are exposed to (and expected to be used by) the consuming code, as opposed to "private" dependencies that are not exposed, and are only an implementation detail.

We still need jQuery in peerDependencies instead of dependencies because we actually expect the user to install it. We cannot simply remove it because we still need the package managers to check for versions compatibilities and warn the user if it is missing.

Related to https://github.com/zurb/foundation-sites/pull/11294 See https://github.com/zurb/foundation-sites/issues/11290