Closed ghost closed 6 years ago
Use call(get-function("shake")) instead.
So we should migrate these. Is this supported in Sass 3?
@hal869 I'm also having this issue. Did you find anything to resolve?
It is not a real issue, just a warning. Deprecated does not mean it does not work. We have to change the parts where the deprecated code is used.
@DanielRuf you are right. I'm on "webpack": "^3.11.0",
and "foundation-sites": "~6.4.4-rc1",
and the warnings aren't breaking anything.
I also found I'm only getting the warnings when I've included the following:
@import "motion-ui";
@include motion-ui-transitions;
@include motion-ui-animations;
Removing the animations fixes all the warnings for me.
@import "motion-ui";
@include motion-ui-transitions;
I don't use the animations that much on my projects so for now this fix will clean up those warnings.
I fixed the problem by editing two files in /node_modules/motion-ui/src/util/
in /node_modules/motion-ui/src/util/_args.scss
replacing @return call($arg);
by @return call(get-function($arg));
in /node_modules/motion-ui/src/util/_keyframe.scss
replacing $map: call($map);
by $map: call(get-function($map));
Question ? How can I submit this ?
You can fork the repository, create a new branch from the main branch, do the changes there and create a new pullrequest for it on the main repository (which you forked).
Ok thanks, I will try this.
I really need to fork ?? I can't just push a new branch on the main repository ?
Right. No and this is discouraged. Also this is how Git works. Every contributor has a copy.
Okay. I'll do that;) Thanks for the advice.
oh sorry, it seems that someone before me is made this correction.
commit: 9d9add547340b6f8a7d5c77067e894799ad86549
How can I update this version when installing zurb template?
You can use also commit hashes with npm. So far there is no new tagged release so this is the only option.
Try npm i zurb/motion-ui#master
for example.
on a webpack4'd foundation6 project
Currently, on webpack exec, I get
the function calls are originating from
removing
eliminates all of those^ deprecation notices on webpack exec
The relevant reference appears @
http://sass-lang.com/documentation/file.SASS_CHANGELOG.html#3_5_0__12_July_2017_