foundationkit / FoundationKit

Everything that really should be in Foundation, but isn't. Future-proof with ARC
Other
80 stars 9 forks source link

Audio in FoundationKit #21

Open MSch opened 13 years ago

MSch commented 13 years ago

It seems that if you build a .framework out of FoundationKit NKAudioRecorder fails, since it depends on AudioToolbox. It works for a static library.

My understanding is that this is since frameworks have dependencies (and AudioToolbox is missing) while static libraries don't have any dependencies to begin with (the embedding app has to provide the dependencies)

Please check out my branch that adds a .framework target for Mac OS X bd6cfe285950311fc49ce245cabf74974103c515

I wasn't against the inclusion of NKAudioRecorder since I thought AudioToolbox gets pulled in by Foundation, but that has been wrong. We should therefore remove NKAudioRecorder (and move it to iOSKit/MacKit instead?)

MSch commented 13 years ago

Or is it possible to weak-link the framework? And should we do that?

MSch commented 13 years ago

I've now weakly linked the necessary Audio frameworks. See 5d67236742f6c038f051

eaigner commented 13 years ago

What's 'weak' linking? If it doesn't work, just remove it. We shouldn't sacrifice the ease-of-use for certain classes, should we?

MSch commented 13 years ago

Yeah, I +1 for removal

myell0w commented 13 years ago

+1 for removal/moving to MacKit.