search

foundationkit / FoundationKit

Everything that really should be in Foundation, but isn't. Future-proof with ARC
Other
80 stars 9 forks source link

Remove parts of ConciseKit #23

Closed MSch closed 13 years ago

MSch commented 13 years ago

IMO...

  1. we should remove $str and $mstr in NSString+NKConcise.h
  2. we should change $null in NSNull+NKConcise.h to NKNullToNil

What do you think?

steipete commented 13 years ago

Hmmm... any reasoning for that?

MSch commented 13 years ago
  1. Gut feeling
  2. macro bad, function good
myell0w commented 13 years ago

ad 1. doesn't this fall under the category 'premature optimizations'?

MSch commented 13 years ago
  1. no, i'm not optimizing anything. i'm trying not to overarchitect (is anyone of us using $str/$mstr -> if not remove it)
steipete commented 13 years ago

I don't need it - although the $str could become handy (if i get used to it) point 2 makes sense though

myell0w commented 13 years ago

I'm not using anything yet, but it looks handy

sent from phone

Am 10.07.2011 um 11:11 schrieb MSchreply@reply.github.com:

  1. no, i'm not optimizing anything. i'm trying not to overarchitect (is anyone of us using $str/$mstr -> if not remove it)

Reply to this email directly or view it on GitHub: https://github.com/foundationkit/FoundationKit/issues/23#issuecomment-1541205

MSch commented 13 years ago

Ok, +1 for keeping $str/$mstr

myell0w commented 13 years ago

Closing this for now, feel free to reopen.