foundeo / cfdocs

Repository for the cfdocs.org site.
https://cfdocs.org/
Other
180 stars 341 forks source link

Update discouraged.md #1611

Closed pczarn2 closed 1 year ago

pczarn2 commented 1 year ago

Added int to discouraged functions.

pfreitag commented 1 year ago

@pczarn2 two things on this:

1) Do you know why Adobe recommends using floor instead of int? It would be useful to know the reason, for example does it support larger numbers than int?

2) The discouraged markdown is generated automatically by adding a discouraged flag on the function or tag, rather than editing this file.

pfreitag commented 1 year ago

Ah - I see you have done this in #1610

KamasamaK commented 1 year ago

@pczarn2 If you're autogenerating this using /utilities/guide.cfm then this shouldn't require a manual review. I think this is just waiting on #1610.

zspitzer commented 1 year ago

As a heads up, Lucee already internally just uses Math.floor() for int()

https://github.com/lucee/Lucee/blob/5.3/core/src/main/java/lucee/runtime/functions/math/Int.java#L36

pczarn2 commented 1 year ago

Closing, since the discouraged markdown is generated automatically by adding a discouraged flag on the function or tag, rather than editing this file.