foundeo / cfdocs

Repository for the cfdocs.org site.
https://cfdocs.org/
Other
180 stars 341 forks source link

replaceNoCase #1616

Open cffoundry opened 1 year ago

cffoundry commented 1 year ago

The description fails to identify the "substring2" or "replacement" (whichever you prefer to call it) argument, yet it is shown in the examples. Adobe has the same error on their website, but likewise has examples with the replacement argument being used.

pczarn2 commented 10 months ago

Looks fine to me, I don't see an issue. The way it's written, it has both string and substring1 as arguments, where substring1 is the one that's replacing string.

replaceNoCase(string, substring1, callback [, scope]) → returns string

string.replaceNoCase(substring1, callback[, scope])

cffoundry commented 10 months ago

Yes - agreed. I realized it after I submitted it.

Sorry for the bother.

Regards, Marc

On Sep 29, 2023, at 1:54 PM, Pawel Czarnota @.***> wrote:

Looks fine to me, I don't see an issue. The way it's written is has both string and substring1 as arguments, where substring1 is the one that's replacing string.

replaceNoCase(string, substring1, callback [, scope]) → returns string

string.replaceNoCase(substring1, callback[, scope])

— Reply to this email directly, view it on GitHub https://github.com/foundeo/cfdocs/issues/1616#issuecomment-1741283755, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTMJ2T2CTJ2N3YKNDI77X3X44DMDANCNFSM6AAAAAAUFNZMAQ. You are receiving this because you authored the thread.