Open garethedwards-tass opened 8 months ago
For these changes in particular the goal was to reduce additional changes to the json files
base_param_index
should be a number, not a string.returns
is set to any
for all of them, which should not be the case.I don't feel it's necessary to have this utility as part of the commit. As you said, it's a "run once" utility and we should expect newly added functions to include member_details
. I would recommend just including the JSON file changes in the commit and update the returns
values. They will usually be the same as the returns
value of the function itself, and in the rare cases it's not you can manually correct that before committing.
@KamasamaK I've removed the utilities
@KamasamaK I've updated the return types
@garethedwards-tass - in general I'm ok with adding the member_details, but as for the utility is there a reason to use custom built json functions, rather than the builtin:
isJSON
,serializeJSON
anddeserializeJSON
?