foundeo / toscript

Converts Tag based CFML to CFML Script
GNU General Public License v3.0
20 stars 9 forks source link

Custom argument attributes not carried over #36

Open pfreitag opened 5 years ago

pfreitag commented 5 years ago

Code such as:

<cfargument name="controller" inject="coldbox">

Does not pass the inject argument over.

Could be converted as:

any controller inject='coldbox'

Note that the type may be required in this case.

KamasamaK commented 5 years ago

I think it is fine, and personally preferred, to include the type when converting. I know this is beside the point, but the example conversion should not have required.

pfreitag commented 5 years ago

Yeah I think it is ok to add any in that case too, thanks for offering your opinion. I removed required from the original comment.

KamasamaK commented 5 years ago

Possibly related to #34