search

foundeo / toscript

Converts Tag based CFML to CFML Script
GNU General Public License v3.0
20 stars 9 forks source link

`public` is used for function without access argument #9

Open mjhagen opened 7 years ago

mjhagen commented 7 years ago

<cffunction name="myFunc"> is converted to public function myFun() (adding public)

KamasamaK commented 7 years ago

Since public is the default access this is semantically consistent. I suppose the issue then might be that it's not a verbatim translation. So the issue really comes down to whether the conversion should be opinionated on best practice.

mjhagen commented 7 years ago

@KamasamaK, yeah I just reported it for that purpose. Couldn't think of a way this would be a problem though. Very low priority (maybe even no priority :))