search

foundeo / ubuntu-nginx-lucee

Script for standing up a Lucee server using nginx and Tomcat on Ubuntu
Apache License 2.0
86 stars 47 forks source link

Lucee 5 and Ubuntu 16.04 LTS Support #11

Closed pfreitag closed 7 years ago

pfreitag commented 8 years ago

This script needs to be updated for both Lucee 5 and Ubuntu 16.04 LTS.

My thoughts are to take the current master branch and create a new branch called lucee45-ubuntu14 and then update master to work with Lucee 5 and Ubuntu 16.04 - the main differences in 16.04 is that it includes Tomcat 8 instead of Tomcat 7.

Ideally the master (lucee 5) branch would still work with Ubuntu 14.04 as well.

Pull request #10 from @andyj adds Lucee 5 support but it uses the Viviotech installer which includes a bundled version of tomcat (so you have to patch tomcat manually).

andyj commented 8 years ago

That sounds great.

Tbh bin my pull request. It's not right.

On 7 June 2016 at 17:44:31, Pete Freitag (notifications@github.com) wrote:

This script needs to be updated for both Lucee 5 and Ubuntu 16.04 LTS.

My thoughts are to take the current master branch and create a new branch called lucee45-ubuntu14 and then update master to work with Lucee 5 and Ubuntu 16.04 - the main differences in 16.04 is that it includes Tomcat 8 instead of Tomcat 7.

Ideally the master (lucee 5) branch would still work with Ubuntu 14.04 as well.

Pull request #10 https://github.com/foundeo/ubuntu-nginx-lucee/pull/10 from @andyj https://github.com/andyj adds Lucee 5 support but it uses the Viviotech installer which includes a bundled version of tomcat (so you have to patch tomcat manually).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/foundeo/ubuntu-nginx-lucee/issues/11, or mute the thread https://github.com/notifications/unsubscribe/AAD-LBnn6y6bOfyMysF7cNUxF71pEv0aks5qJZ_vgaJpZM4IwIL- .

lxcodes commented 8 years ago

@pfreitag Can you create a new Lucee 5 / Ubuntu 16.04 branch to accept pull requests into?

pfreitag commented 8 years ago

@al3x-edge I have created a lucee5 branch.

pfreitag commented 8 years ago

@al3x-edge thanks for your PR to add Lucee 5 support. Ubuntu 16.04 supports either tomcat7 or tomcat8, we should probably add a variable TOMCAT_VERSION and use that throughout the scripts to add tomcat8 support. The main bit of work there is to add etc/tomcat8 with appropriate changes.

lxcodes commented 8 years ago

@pfreitag Sounds like a great idea. I'll add that in.

jfrux commented 7 years ago

Did this ever go anywhere?

pfreitag commented 7 years ago

@joshuairl yes the master branch has been switched to lucee 5, I don't think we have added a TOMCAT_VERSION option yet however.

pfreitag commented 7 years ago

I haven't added the TOMCAT_VERSION variable but I have updated the scripts to use tomcat8, if you really want to use tomcat7 you can edit the scripts I don't think there is much need to support tomcat7 at this point.