search

founderlab / react-dropzone-s3-uploader

Drag and drop s3 file uploader via react-dropzone + react-s3-uploader
MIT License
161 stars 82 forks source link

Passing in onDrop prop causes handleDrop to be bypassed #46

Open juchiu opened 6 years ago

juchiu commented 6 years ago

The rest operator on dropzoneProps overrides the onDrop prop.

https://github.com/founderlab/react-dropzone-s3-uploader/blob/3f55cac24f4cce024a7666764cefc0eca8f83bc6/src/DropzoneS3Uploader.js#L195

traveled1 commented 6 years ago

I have the same issue. Any workaround? Thanks in advance!

dancrumb commented 6 years ago

For the time being, you can add onDrop to the notDropzoneProps property.

This just burned me for a whole day, so it would be great to get this documented, at the very least

dancrumb commented 6 years ago

see #58