search

foundersandcoders / Live-Peers

2 stars 2 forks source link

change live-peers to a react redux app? #107

Open jsms90 opened 6 years ago

jsms90 commented 6 years ago

@njsfield I know we talked about this before. How would you feel about using react and redux for live-peers?

@esraajb @njsfield Would you mind if this repo changed? Should we keep this one with Hapi & make a new one?

njsfield commented 6 years ago

:thumbsup:

I've thought about this quite a few times! If I can find time, I'd be happy to review PRs/answer questions about the current API and key features for whoever would like to develop this in react/redux.

I propose;

  1. Adding tests (and fixing bugs) on the server, so that a solid API is available.
  2. Write a front-end react/redux app (utilising same design & css for the current app) that integrates similarly with the API
  3. Finally incorperate several start scripts; 
    npm run start-react

    To start the server, and serve the react-bundled code from a designated directory, and...

    npm run start-vanilla

    To start the server, and serve the current static js assets we have in this repo (for vanilla implementation of the app).

This would allow devs to contribute to this repo in both areas; vanilla implementation & react/redux (and eventually Elm :p).

iteles commented 6 years ago

If you guys do this, I suggest it would be great to document your reasoning too 👍🏻

jsms90 commented 6 years ago

Now I'm learning Elm again & wanna use that :sweat_smile: Unless we ever actually put Elm into the curriculum permanently, React/Redux would make it easier for students to jump into the codebase and encourage contributions. :thinking:

So part of this is obviously using a project I like and care about to help me learn whatever new piece of Tech I'm playing with at the time...but if we do actually wanna use this in FAC at some point, we might as well choose a framework that means we're not gonna experience runtime errors... :stuck_out_tongue_winking_eye:

I'm thinking of trying to Elm-ify this at the end of this week. If I do, I'm thinking I would make a new repo & steal the assets from this one. But would that be ok with you @njsfield ?