search

foundersandcoders / express-handlebars-workshop

7 stars 10 forks source link

Confusing flow of files - Diagram may help(included) #15

Closed mineshmshah closed 5 years ago

mineshmshah commented 6 years ago

The flow for this exercise in the way that how express calls handlebars is confusing. I created a flow diagram(below) to explain the flow a bit better which people found helpful. Maybe wise to include it so students can visualise things better.

express handlebars flow chart

Johanna-hub commented 6 years ago

Thanks @mineshmshah, this was super useful!

eliasmalik commented 6 years ago

@mineshmshah do you have the source file that generated this diagram, so we can make edits?

jamiecoe commented 6 years ago

@eliascodes Minesh has given me the source file, so we can make edits 🎉 Was there anything that needed to be changed? Just double checked and I think it's still up-to-date with our workshop instruction edits.

If no edits are necessary, I can add this diagram to the Readme?

eliasmalik commented 6 years ago

@jamiecoe if the diagram looks sensible to you, I'm happy for you to leave it as is. Though I'd like the source file for the diagram to be committed, perhaps you can rename the images-readme directory to assets or docs or something and stick it in there?

thejoefriel commented 6 years ago

Hi @mineshmshah - I'm on fac14 and currently doing curriculum review. It appears this image was added to the readme so are you happy to close this issue?