search

foundersandcoders / nazareth-recipes

An open source, co-operatively produced hub for communal Founders & Coders recipes
GNU General Public License v3.0
61 stars 0 forks source link

Freaky Freekeh #37

Closed Suuuuha closed 6 years ago

Suuuuha commented 6 years ago

update 7/1/18 by @mattlub:

update 29/1/18:

mattlub commented 6 years ago

...

Karyum commented 6 years ago

I think this is literally the smallest pull request i have ever seen :laughing:

Karyum commented 6 years ago

@Suuuuha @mattlub @m4v15 for the lack of contributions to this PR would probably be a good idea to close. BY THE POWER GIVEN BY THEE or something like that

mattlub commented 6 years ago

reopening and assigning to @Suuuuha because I would like to cook this.

Karyum commented 6 years ago

@matthewdking is using Suha's requested change in my PR as an argument in where i can't merge the Arabic Omelette.

So im using this PR just to state that Arabic Omelette would have been never merged if we waited for other people

and @m4v15 i believe there is nothing you could here. GO read the contribution file and see what it says and then check my PR

m4v15 commented 6 years ago

I don't think this is the place for this discussion... however, in the contributing guide:

A PR should never be merged if a reviewer has requested changes and not yet re-reviewed it.

Happy?

Karyum commented 6 years ago

@m4v15 I know mate it says that but at look at this. You can't use PRs as issues mate you can't just open an empty PR just to add some stuff later . for me this is considered even worse than pushing to master, cause there is a few reasons why you might push to master, but there is no reason behind this mate

m4v15 commented 6 years ago

Yeah to be honest I'm not sure how I feel about this PR being used as it is but that is a completely separate issue to you merging your own PR, not sure why you are conflating them.

Karyum commented 6 years ago

@m4v15 Im just showing you my reasoning behind skipping @Suuuuha review (which is the same review that @matthewdking borught up)

Karyum commented 6 years ago

I'm sorry but this has to happen at some point :rofl:

mattlub commented 6 years ago

@Karyum I will reopen this at some point and complete it myself if needs be. MARK MY WORDS :shipit:

Karyum commented 6 years ago

@mattlub both of you guys are pretty busy people, so pretty sure nothing would get done :laughing:

Suuuuha commented 6 years ago

@mattlub sweeeet :heart:
just fix the typo and :shipit:

Karyum commented 6 years ago

@mattlub did you actually just approve changes that you made ? this is nonsense i call BS :rofl:

mattlub commented 6 years ago

@m4v15 @Karyum @matthewdking review + merge pls, this recipe needs to be shipped 🚢 🇮🇹