Closed matthewdking closed 6 years ago
I'm making this now (thanks, and hi from London 😋 ) and I don't think there's anything in the recipe telling you what to do with the chillies? (Assuming to add to the sauce along with the onion, garlic, and ginger.)
@bradreeder good spot! Remove the seeds from the chillies and then finely chop them and add them with the onion garlic and ginger. I will add it to the recipe now! Hope you enjoy it :man_cook: :fork_and_knife:
@matthewdking I think I went overboard on the chillies 🔥 🚒 but v nice thanks, have enough leftover for the weekend.
@bradreeder you should star this repo ⭐️ !
@yvonne-liu errr you should wait until everyone has approved the pull request before merging m8
@m4v15 "Once a pull request has been reviewed by 3 people who ate the meal, as well as or including a maintainer, it can be merged." 👋
@yvonne-liu Firstly, that comes under the section titles "Instructions for maintainers" which you are not. Second of all, even if it didn't, the "3 people who ate the meal" criteria wasn't fulfilled here as @finnhodgkin did not, and third of all, I would think it is safe to assume/implied knowledge that you don't merge a PR when someone has requested changes and is yet to approve it.
I mean, I was joking at first, but now this is serious
Oh also I mean just cos I had requested changes and not reviewed it, not all the other people who hadn't reviewed it
you can apologise here or on WhatsApp, either works ❤️
I'd consider apologizing, but I'll never apologise 💔
that'll do
you don't merge a PR when someone has requested changes and is yet to approve it
@yvonne-liu agree with @m4v15 about this, should it be stated in the guidelines?
relates #40