Closed Karyum closed 6 years ago
In all seriousness I think we shouldn't be too strict on 100% correct english - we after all don't have a style guide (yet..?) so some things could be very debatable. As long as the message is gotten across I actually think I quite like the small idiosyncrasies of mario's (and others) written english. Like this might be slightly patronising I guess but I think more it would be nicer for each recipe to have the voice of the author within it, with the way that it is written. ❤️
@m4v15 I love what you said but @matthewdking @finnhodgkin are haters
@shiryz I believe you have some interesting opinions on this?
So we have 2 maintainers approval and 2 people approval who request big change ( like a lot ).
This can be merged now
@Karyum ! You can't merge your own PRs! and @Suuuuha has changes requested that she hasn't reviewed yet
@m4v15 no where it states that i can't merge my own PR NO WHERE even on master reference it doesn't say. we only explain to students in the course just for good practices with team and having a qa
I mean c'mon, standard practice! the whole place would fall apart without these things! It's not stated anywhere because it's assumed knowledge! Otherwise what's the point in making branches, just commit to master!
@m4v15 Mate 2 maintainer approved 2 people who made lots of changes approved i just mentioned on the reason i skipped @Suuuuha Click here I have all the rights now to push it back and merge it
Why didn't you just ask suha to re-review it?
You could have said, guys can someone merge it now please otherwise it will take ages - you shouldn't have taken the matters into your own hands
rel #8
I can't find any pics for the Arabic Omelette on my phone if anyone has a picture of it please add it to the PR thanks!