search

foundersandcoders / nazareth-recipes

An open source, co-operatively produced hub for communal Founders & Coders recipes
GNU General Public License v3.0
61 stars 0 forks source link

Arabic omellete #54

Closed Karyum closed 6 years ago

Karyum commented 6 years ago

close #8

Only giving the chance to @finnhodgkin and @matthewdking to be able to merge cause @m4v15 is controversial right now

m4v15 commented 6 years ago

I'm glad you've come to your senses. However I would point out you need 3 reviewers including a maintainer - are you suggesting one of @matthewdking or @finnhodgkin get's promoted? We need a protocol for that ugh

Karyum commented 6 years ago

@m4v15 I mean i could say the same thing for you revert PR, it needed 3 reviewers and a maintainer. I'm not sure you are allowed in this PR anymore.

shiryz commented 6 years ago

@Karyum can we call it Mario's Omlette instead?

Karyum commented 6 years ago

@shiryz We could but that would just bloat my ego and then other people my see it and start doing the same

shiryz commented 6 years ago

Makes sense, but given that we haven't come to a consensus on what an arabic omlette is I call for an emergency naming convention

Karyum commented 6 years ago

@shiryz I say in my PR that i give the base of the Arabic omelette and said that people can get creative with it

finnhodgkin commented 6 years ago

I reckon we give @Suuuuha / @mattlub until the end of the day to re-review and then hopefully get one of the maintainers to merge with or without approval... They can always request changes via issues at a later date. :+1: :heart: