search

foundersandcoders / oauth-workshop

8 stars 3 forks source link

confusion about get/post in step 5 #10

Open jsms90 opened 7 years ago

jsms90 commented 7 years ago

We write a GET request, whose handler then makes a POST request. This could be made much clearer. "the necessary paramters" is unnecessarily cryptic in

Send a POST request to the relevant endpoint on the Github API - time to go back to the Github docs. Don't forget to include the necessary parameters in the body of your request.

Instead, this should make clear reference to the fact that we're are using: client_id client_secret code

in order to get back the code