Open mattlub opened 7 years ago
@JWLD @mattlub Just wanted to make you aware that currently, the post request to /register expects a particular kind of body, like this:
const { englishName, arabicName, email, username, imageUrl } = req.body
const en = englishName && { name: englishName }
const ar = arabicName && { name: arabicName }
return Users.create(Object.assign(
{
username: username,
password: passwordHash,
role: roles.BASIC,
email: email,
imageUrl: imageUrl
},
{ ar },
{ en }
))
we can allow for organisation name as englishOrgNam and arabicOrgName (didn't do it originally but am going to do it before the PR is finished
Those endpoints look good to me - you know what each form is POST ing to as well yeah?
Are we going to get rid of the user endpoints on the API?
Or I guess we always said we'd just secure these for only SUPER
@mattlub they look good.
scope done for this sprint
high priority:
GET /login
)GET /register
)User
model for required fieldsGET /oauth/authorize
)client_id
,redirect_uri
,state
(iirc- check them)lower priority:
GET /oauth/register-app
)Client
model for required fields@des-des @m4v15 thoughts on the endpoints I've suggested?