foundersandcoders / open-tourism-platform

An open platform to facilitate the creation of apps to promote local tourism and business in Nazareth
MIT License
17 stars 3 forks source link

Object to dot notation #145

Closed m4v15 closed 6 years ago

m4v15 commented 6 years ago

addresses #144

des-des commented 6 years ago

@m4v15 I think this might get someone into all kinds of trouble if somewhere down the line we needed nested objects in body..

des-des commented 6 years ago

@m4v15 what about this: https://github.com/Automattic/mongoose/issues/5285#issuecomment-309124718

m4v15 commented 6 years ago

Yeah I did sort of think this, I think we might be better just making this a helper function we can call when we need it, as we might need it when we do field permissions:

I think what I will do is add it as a helper functions, and use that as a pre update and findoneandupdate hook, and then it can be used before the field permission as well if necessary

For now I will put this on hold until #122 and #146 are done

des-des commented 6 years ago

I think this should happen final step before mongoose call

m4v15 commented 6 years ago

hey I'm cleaning my github up, presumably I can close and delete this branch @des-des @Karyum ?

m4v15 commented 6 years ago

actually I can just unassign myself 😅