search

foundersandcoders / open-tourism-platform

An open platform to facilitate the creation of apps to promote local tourism and business in Nazareth
MIT License
17 stars 3 forks source link

fix categories that were listed incorrectly #159

Closed m4v15 closed 6 years ago

m4v15 commented 6 years ago

Have copy and pasted from the constants file to ensure no mistakes

Any change you just wanna merge this @mattlub or @des-des as it is wrong for the data-entry and events team atm

mattlub commented 6 years ago

didn't we do this before? How many mistakes are there?

mattlub commented 6 years ago

also- should we change 'miscellaneous' to 'other' in events categories? Or at least add 'other'?

m4v15 commented 6 years ago

Yeah I think we should, but not in this PR

m4v15 commented 6 years ago

Actually, none other than cultural event => culture

I guess this way was just making sure there were definitely no other mistakes.

Suuuuha commented 6 years ago

@m4v15 @mattlub in my opinion, in the accessibility options - 'place for guide dog' could be changed to 'guide dog allowed' or sth for clarity. since in israel there are no places for guide dog but dogs might be allowed if the place is friendly accessible.

mattlub commented 6 years ago

@m4v15 I think if it's gonna be json, we should just link to the constants file, so we don't have to change things in multiple places.

m4v15 commented 6 years ago

lol did not notice your comment here @Suuuuha. Again, we can definitely change some categories, but this PR is for fixing the currently wrong docs, not for changing the categories. Raise an issue?

@mattlub Yes you are probably right, I will do this now, sorry. Back to how it was originally lol.