Implement error handling using custom middleware - Githubissues

foundersandcoders / open-tourism-platform

An open platform to facilitate the creation of apps to promote local tourism and business in Nazareth

MIT License

17 stars 3 forks source link

Implement error handling using custom middleware #74

Closed m4v15 closed 7 years ago

m4v15 commented 7 years ago

NO LONGER A WIP

tidies up the 4 controllers (they are all identical)
changes some of the tests as the error messages have changed.
adds package-lock.json
add handling of mongo duplicate key error

N.B. tests could be cleaned up, but I think this is a separate job- e.g. abstracting out the tests as they are all the same.

relates #71

coveralls commented 7 years ago

Coverage decreased (-0.7%) to 88.776% when pulling 10627fb876a532e6ed33499f467b1b20d08e88bb on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 88.889% when pulling b4cffd27318788013400f05c2b993b87b0bf873b on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

coveralls commented 7 years ago

Coverage decreased (-0.7%) to 88.837% when pulling 4f336451c48e76e147a5760b41c8ecc2147b6c57 on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

coveralls commented 7 years ago

Coverage decreased (-2.1%) to 87.391% when pulling ba2138418daf1cab37047d20c46b324116257ec3 on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

coveralls commented 7 years ago

Coverage decreased (-4.6%) to 84.937% when pulling 7916d1b33d979726d2932062784e673af365c2e7 on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

coveralls commented 7 years ago

Coverage increased (+0.08%) to 89.583% when pulling f308c8a7a56149cb885c10cc88a81bb1663f3a3d on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

coveralls commented 7 years ago

Coverage increased (+1.03%) to 90.535% when pulling 7b33c7dd8e7325d4c02b4abf2781060cbe5dfb34 on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

coveralls commented 7 years ago

Coverage increased (+1.5%) to 91.051% when pulling 5f94a180488a0e1009fd5ef41c7a9bed8acdb186 on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

coveralls commented 7 years ago

Coverage increased (+1.5%) to 91.051% when pulling 0b128826dd2b9b82a0881dcd0ebc2e10d3fccb7a on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

coveralls commented 7 years ago

Coverage increased (+1.5%) to 91.051% when pulling a1b8070d46cfea17df9b41e416fe60b0290e91f2 on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

coveralls commented 7 years ago

Coverage increased (+2.03%) to 91.532% when pulling a49e93fb3b5bd736b0dcabf79c4cc7cc569f5eda on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

coveralls commented 7 years ago

Coverage increased (+2.5%) to 92.05% when pulling 6dea2ea518361331575a7235e6cdafe0fadce348 on error-handling into f6e0c25fbdf2c0ba857f06aabaa48911fc224506 on master.

m4v15 commented 7 years ago

as long as you don't get the contributions for the package-lock.json, I'm happy