foundersandcoders / prereq-check

A FAC application prerequisite checker: to be used by applicants and the selection committee :fire:
https://prereq-check.herokuapp.com
18 stars 2 forks source link

Sign in with GitHub to access app #8

Closed ameliejyc closed 6 years ago

ameliejyc commented 7 years ago

As a selection panel member I can login with my GitHub account to access the app. As an applicant I can login with my GitHub account to access the app.

Acceptance criteria:

login page with info

BartBucknill commented 7 years ago

I was a wondering how easy it would be to get the username of the signed in user from github oauth as I couldn't see it in the docs. I found this stackoverflow question which seems to provide the answer, basically making a call the github api with the access token from the login in order to get the username.

dangerdak commented 7 years ago

This is dependent on #10 - it isn't necessary unless that's done, as only the meetup data needs to be kept private, the rest is publicly available anyway.

dangerdak commented 7 years ago

Something to decide on: sessions vs authorization token